Fix vm_lifecycle quicktest to use specified SR #5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5489 +/- ##
========================================
+ Coverage 49.0% 51.8% +2.7%
========================================
Files 18 19 +1
Lines 2319 2586 +267
========================================
+ Hits 1138 1341 +203
- Misses 1181 1245 +64 see 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
This test did not exercised the SR type expected by user, and notably failed when no default SR was defined. Adds the option of installing a VM in a non-default SR using VM.with_new. Signed-off-by: Yann Dirson <[email protected]>
lindig
approved these changes
Mar 11, 2024
|
I'm building and testing, will approve and merge once the tests have passed |
psafont
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands this test uses the default SR even though user specifies one throught quicktest -sr, and fails when run on a pool with no default SR.
This makes it use the SR from command-line instead.
This is the master version of #5488.