change template-pathname->output-name to reliably match pathnames on ccl + linux #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
running make-project on ccl64 1.11.5 on linux, the template files do not get renamed to match the project name the problem seems to be that (pathname-match-p "/some/expanded/template.name" "template.name") is not true. I always get confused about pathname conversion, so I added a function that drops this down to a string compare between file name and file type
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fro me, running make-project using ccl64 1.11.5 on linux, the template files do not get renamed to match the project name
the problem seems to be that
(pathname-match-p "/some/expanded/template.name" "template.name")is not true in this systemI always get confused about pathnames, so I have added a small function that drops this down to a string compare between file name and file type, which is probably a grotty way to do it, but fixes my problem