-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): add configurable connection limits for each subgraph #1558
Open
endigma
wants to merge
4
commits into
main
Choose a base branch
from
jesse/eng-6338-make-transport-connection-limits-configurable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(router): add configurable connection limits for each subgraph #1558
endigma
wants to merge
4
commits into
main
from
jesse/eng-6338-make-transport-connection-limits-configurable
+82
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Router image scan passed✅ No security vulnerabilities found in image:
|
8c212c4
to
e33640a
Compare
e33640a
to
7a1c6a9
Compare
With the changes introduced in #1567 this PR is now a good bit simpler and the previously somewhat complex interaction with TimeoutTransport is now gone. |
StarpTech
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
df-wg
approved these changes
Feb 5, 2025
7a1c6a9
to
51d9837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Users want to configure connection limits for the router, including per-subgraph values.
Checklist
Example config utilizing this feature: