Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase max concurrent resolvers #1544

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

StarpTech
Copy link
Contributor

Motivation and Context

Based on our observations in production and feedback from customers, we have concluded that the ENGINE_MAX_CONCURRENT_RESOLVERS value was set too low. Additionally, we have resolved a potential memory issue that we previously misattributed to this limit. A value that is too low can lead to increased latency in subgraph requests due to limited concurrency.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

Copy link

github-actions bot commented Jan 29, 2025

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-40e4cfa19ddbda071b20b04b48b4061e2a1d7044

@StarpTech StarpTech merged commit 00e2ee8 into main Jan 29, 2025
12 checks passed
@StarpTech StarpTech deleted the dustin/increase-max-concurrent-resolver branch January 29, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants