Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade ristretto to v2 #1538

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Conversation

StarpTech
Copy link
Contributor

@StarpTech StarpTech commented Jan 28, 2025

Motivation and Context

Checklist

Fixes since https://github.com/dgraph-io/ristretto/releases/tag/v2.0.0

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

@StarpTech StarpTech requested review from df-wg, Noroth, alepane21 and devsergiy and removed request for df-wg January 28, 2025 10:37
Copy link

github-actions bot commented Jan 28, 2025

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-5a64186b1f65dbed80b90eec2e706a6741da47f6

Copy link
Contributor

@alepane21 alepane21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small issue with the imports order, I tried for some regression with the
make test-parallel and haven't found one, so this change looks good to me!

graphqlmetrics/core/metrics_service.go Outdated Show resolved Hide resolved
@StarpTech StarpTech requested a review from alepane21 January 28, 2025 16:41
@StarpTech StarpTech merged commit 3f184cd into main Jan 28, 2025
15 checks passed
@StarpTech StarpTech deleted the dustin/upgrade-ristretto branch January 28, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants