feat(router): enable starting the router without subgraphs #1533
+224
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df-wg
commented
Jan 24, 2025
Router image scan passed✅ No security vulnerabilities found in image: |
jensneuse
requested changes
Jan 24, 2025
jensneuse
reviewed
Jan 24, 2025
df-wg
force-pushed
the
dave/eng-5954-it-should-be-possible-to-run-the-router-without-subgraphs
branch
from
4b3f5aa to
e156c27
Compare
StarpTech
requested changes
Jan 27, 2025
| CacheSize: 1024 * 1024, | ||
| } | ||
|
|
||
| router, err := routercmd.NewRouter(context.Background(), routercmd.Params{ |
There was a problem hiding this comment.
Instead of doing a hybrid approach, it would be great if we could purely start a router by spawning a process and configure it in the same way as a user would do. By environment variable or router config. We could maintain different presets of .env and router config for maximum flexibility. We should avoid the programmatic api completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Checklist