Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(router): bump demo library to pickup subscription fix #1518

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

df-wg
Copy link
Contributor

@df-wg df-wg commented Jan 20, 2025

Motivation and Context

In 99designs/gqlgen#3329, I solved an issue for our subscription demos, which had been causing a nil pointer error at the conclusion of a bounded subscription:

❯ curl -i -H "Accept: multipart/mixed" -X POST http://localhost:3002/graphql -d '{"query": "subscription { countFor(count: 2) }"}'
HTTP/1.1 200 OK
Cache-Control: no-cache
Connection: keep-alive
Content-Type: multipart/mixed; boundary=graphql
Vary: Accept-Encoding
X-Accel-Buffering: no
Date: Mon, 20 Jan 2025 07:30:54 GMT
Transfer-Encoding: chunked


--graphql
Content-Type: application/json

{"payload":{"data":{"countFor":0}}}

--graphql
Content-Type: application/json

{"payload":{"data":{"countFor":1}}}

--graphql
Content-Type: application/json

{"payload":{"data":{"countFor":2}}}

--graphql
Content-Type: application/json

{"payload":{"errors":[{"message":"internal system error"}],"data":null}}
--graphql--

Now, it doesn't return the internal system error:

❯ curl -i -H "Accept: multipart/mixed" -X POST http://localhost:3002/graphql -d '{"query": "subscription { countFor(count: 2) }"}'
HTTP/1.1 200 OK
Cache-Control: no-cache
Connection: keep-alive
Content-Type: multipart/mixed; boundary=graphql
Vary: Accept-Encoding
X-Accel-Buffering: no
Date: Mon, 20 Jan 2025 12:55:06 GMT
Transfer-Encoding: chunked


--graphql
Content-Type: application/json

{"payload":{"data":{"countFor":0}}}

--graphql
Content-Type: application/json

{"payload":{"data":{"countFor":1}}}

--graphql
Content-Type: application/json

{"payload":{"data":{"countFor":2}}}
--graphql--

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

Copy link

github-actions bot commented Jan 20, 2025

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-e89ae2379db6cfaeb65ec94a9b9d4ec4eac281b8

Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@df-wg df-wg enabled auto-merge (squash) January 27, 2025 09:48
@df-wg df-wg merged commit e89d444 into main Jan 27, 2025
13 checks passed
@df-wg df-wg deleted the dave/bump-demos branch January 27, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants