feat: make router-tests less flaky #1484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Router image scan passed✅ No security vulnerabilities found in image: |
…ss-flaky # Conflicts: # router-tests/go.mod # router-tests/go.sum
…ss-flaky # Conflicts: # router-tests/testenv/testenv.go
df-wg
reviewed
Jan 29, 2025
| res, err := xEnv.MakeGraphQLRequestWithContext(context.Background(), testenv.GraphQLRequest{ | ||
| Query: `{ employees { id } }`, | ||
| }) | ||
| require.NoError(t, err) | ||
| require.Equal(t, res.Response.StatusCode, 200) | ||
| require.Equal(t, `{"errors":[{"message":"Failed to fetch from Subgraph 'employees'."}],"data":{"employees":null}}`, res.Body) | ||
| assert.Equal(t, res.Response.StatusCode, 200) |
There was a problem hiding this comment.
Why do we use assert, rather than require here?
There was a problem hiding this comment.
From what I know, you should use the require only if you don't want the next assertion to run. In this instance I wanted to see the next assertion result to help me debug the issue when the test fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is the second batch of fixes to reduce the flaky tests. In this PR I focused on:
Checklist