Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make cosmo usable with aws s3 #1135

Conversation

AndreasZeissner
Copy link
Contributor

@AndreasZeissner AndreasZeissner commented Sep 2, 2024

Motivation and Context

This enables virtual-host based s3 paths to be used for the S3_STORAGE_URL in the controlplane and the cdn.
When using aws ensure to set the S3_REGION e.g.:

S3_REGION: us-east-1
S3_STORAGE_URL: https://cosmo-bucket.s3.amazonaws.com

By default, the username and password is taken from the url itself.

e.g.: https://username:password@minio:9000/cosmo

This is done for backwards compatibility and can be used by default.

When needed it's possible to pass: S3_ACCESS_KEY_ID and S3_SECRET_ACCESS_KEY for credentials management.
The S3_ENDPOINT is usually built out of the url.orgin but can be passed if needed.

rel: #983

TODO

@AndreasZeissner AndreasZeissner marked this pull request as ready for review September 2, 2024 10:41
@github-actions github-actions bot removed the monorepo label Sep 3, 2024
@AndreasZeissner AndreasZeissner merged commit aa9b72f into main Sep 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants