-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make cosmo usable with aws s3 #1135
Merged
AndreasZeissner
merged 17 commits into
main
from
andi/eng-5603-make-controlplane-compatible-with-s3-buckets
Sep 3, 2024
Merged
feat: make cosmo usable with aws s3 #1135
AndreasZeissner
merged 17 commits into
main
from
andi/eng-5603-make-controlplane-compatible-with-s3-buckets
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnithin
requested changes
Sep 3, 2024
thisisnithin
approved these changes
Sep 3, 2024
This reverts commit ec1ac05.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This enables virtual-host based s3 paths to be used for the
S3_STORAGE_URL
in the controlplane and the cdn.When using aws ensure to set the
S3_REGION
e.g.:S3_REGION
: us-east-1S3_STORAGE_URL
: https://cosmo-bucket.s3.amazonaws.comBy default, the username and password is taken from the url itself.
e.g.: https://username:password@minio:9000/cosmo
This is done for backwards compatibility and can be used by default.
When needed it's possible to pass:
S3_ACCESS_KEY_ID
andS3_SECRET_ACCESS_KEY
for credentials management.The
S3_ENDPOINT
is usually built out of the url.orgin but can be passed if needed.rel: #983
TODO