Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use solar_angle_equivalency and Helioprojective.is_visible() #100

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

wtbarnes
Copy link
Owner

Fixes #94
Fixes #91

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.24%. Comparing base (fde01b8) to head (ec1d3bc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
synthesizAR/instruments/base.py 42.85% 4 Missing ⚠️
synthesizAR/visualize/fieldlines.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   51.14%   51.24%   +0.09%     
==========================================
  Files          40       40              
  Lines        2100     2092       -8     
==========================================
- Hits         1074     1072       -2     
+ Misses       1026     1020       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtbarnes wtbarnes merged commit 0d3bbd6 into main Oct 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculate pixel area using solar_angle_equivalency Replace util.is_visible with Helioprojective.is_visible
2 participants