Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some internal utils functions private #332

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

wtbarnes
Copy link
Owner

@wtbarnes wtbarnes commented Oct 1, 2024

Fixes #330
Fixes #331

This reduces the visibility of some utils functions that are used internally.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.55%. Comparing base (f996aea) to head (f0de2e9).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
fiasco/util/setup_db.py 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   90.54%   90.55%   +0.01%     
==========================================
  Files          40       41       +1     
  Lines        3394     3400       +6     
==========================================
+ Hits         3073     3079       +6     
  Misses        321      321              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtbarnes wtbarnes merged commit 9dd7fac into main Oct 2, 2024
14 checks passed
@wtbarnes wtbarnes deleted the db-write-changes branch October 2, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make some util methods private Database file write should error if file already exists
1 participant