Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isoelectronic sequence property and helper function #320

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

wtbarnes
Copy link
Owner

Ions in the same isoelectronic sequence (i.e. those that have the same number of bound electrons) often share common properties despite having different charge states and being from different ions. As such, it is often useful to know to which isoelectronic sequence an ion belongs or to group ions of a single sequence together.

As such, this PR adds two features:

  • Add a isoelectronic_sequence property to fiasco.Ion
  • Add a helper function fiasco.get_isoelectronic_sequence that returns all ions in CHIANTI that fall within a given isoelectronic sequence.

@wtbarnes wtbarnes marked this pull request as ready for review September 30, 2024 01:11
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (545da0a) to head (d9bdfaf).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   90.47%   90.92%   +0.45%     
==========================================
  Files          40       40              
  Lines        3369     3384      +15     
==========================================
+ Hits         3048     3077      +29     
+ Misses        321      307      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtbarnes wtbarnes merged commit a661c8c into main Sep 30, 2024
14 checks passed
@wtbarnes wtbarnes deleted the isoelectronic-sequence branch September 30, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant