Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize needs_dataset decorator to non-Ion objects #316

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

wtbarnes
Copy link
Owner

Fixes #315

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.14%. Comparing base (7256ed3) to head (25a4f37).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
fiasco/util/tests/test_decorator.py 95.65% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   92.65%   93.14%   +0.48%     
==========================================
  Files          37       38       +1     
  Lines        3119     3165      +46     
==========================================
+ Hits         2890     2948      +58     
+ Misses        229      217      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtbarnes wtbarnes merged commit 6642b07 into main Sep 20, 2024
14 checks passed
@wtbarnes wtbarnes deleted the generalize-needs-ds-decorator branch September 20, 2024 07:45
@jwreep
Copy link
Collaborator

jwreep commented Sep 20, 2024

That was fast! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalize the decorator @needs_dataset, which assumes that the input is a fiasco.Ion
2 participants