Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vectorize_where bug and RTD config #241

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Fix vectorize_where bug and RTD config #241

merged 5 commits into from
Jan 8, 2024

Conversation

wtbarnes
Copy link
Owner

@wtbarnes wtbarnes commented Dec 12, 2023

Fixes #239
Fixes #242

This also updates the pre-commit configuration to use Ruff and makes a few minor fixes to comply with the updated style configuration.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb4670e) 91.96% compared to head (9ad9658) 92.55%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   91.96%   92.55%   +0.59%     
==========================================
  Files          23       23              
  Lines        2015     2015              
==========================================
+ Hits         1853     1865      +12     
+ Misses        162      150      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pep8speaks
Copy link

pep8speaks commented Jan 8, 2024

Hello @wtbarnes! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 96:80: E501 line too long (81 > 79 characters)

Line 201:1: E302 expected 2 blank lines, found 1
Line 202:10: E231 missing whitespace after ','
Line 223:80: E501 line too long (81 > 79 characters)

Line 26:34: E225 missing whitespace around operator

Comment last updated at 2024-01-08 17:56:40 UTC

@wtbarnes wtbarnes changed the title Fix RTD config Fix vectorize_where bug and RTD config Jan 8, 2024
@wtbarnes wtbarnes merged commit 800de31 into main Jan 8, 2024
16 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/fiasco that referenced this pull request Jan 8, 2024
wtbarnes added a commit that referenced this pull request Jan 8, 2024
@wtbarnes wtbarnes deleted the fix-rtd-config branch June 16, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix vectorize_where to work with latest version of numpy Update RTD configuration
3 participants