-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Python 3.11 in test suite #176
Conversation
Codecov ReportBase: 86.90% // Head: 86.90% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
=======================================
Coverage 86.90% 86.90%
=======================================
Files 22 22
Lines 1802 1802
=======================================
Hits 1566 1566
Misses 236 236 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hmm it seems there are issues with both the Windows and 3.11 tests:
|
Agreed! I'll raise an issue on this.
That's PlasmaPy's fault here, since we have Numba as a requirement. I've been dreaming of dropping it because of how long it takes for Numba to get released after a few Python version. Hopefully before next year! |
Ah gotcha. I didn't realize it had been picked up as a dependency in plasmapy. Is there room to make it an optional dependency? |
We use it within some of our formulary functions, so we'd have to do some rewriting to make it optional. My own preference would be to cythonize the numba out of everything so that we drop it as a dependency entirely. |
Given the performance improvements with Python 3.11 compared even to just Python 3.10, we can probably save some time with documentation builds and linter checks by switching to 3.11.
windows-latest
in test suite
Just downscoped this to remove the tests for Windows, which are going to be covered in a separate PR (see also #179). And still waiting for Numba to work on Python 3.11... downscope ← my new favorite word |
This is superseded by #245 |
This PR makes two changes to
tox.ini
in preparation for a v0.1.0 release:Change the Python 3.9 test towindows-latest
Because PlasmaPy depends on Numba (at least for now), and fiasco depends on PlasmaPy, it'll be necessary to wait until Numba works on Python 3.11.