Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setter for ionization potential #325

Open
wtbarnes opened this issue Sep 30, 2024 · 2 comments
Open

Add setter for ionization potential #325

wtbarnes opened this issue Sep 30, 2024 · 2 comments
Labels
API API design, naming conventions, etc. effort-low feature Ion Anything related to the Ion object
Milestone

Comments

@wtbarnes
Copy link
Owner

When making an Ion, it is possible to set the abundance through a keyword argument. This keyword argument can be either the dataset name or an actual value. The ionization potential should work the same and should have similar setter/getter logic to how the abundance property works.

@wtbarnes wtbarnes added effort-low feature API API design, naming conventions, etc. Ion Anything related to the Ion object labels Sep 30, 2024
@wtbarnes
Copy link
Owner Author

This should be done in tandem with #323

@wtbarnes wtbarnes added this to the 0.4 milestone Oct 1, 2024
@jwreep
Copy link
Collaborator

jwreep commented Nov 9, 2024

Are there significantly different values or precisions from different atomic databases? I guess I'm wondering why a setter is needed for ionization potential, as it should just be a fundamental property of an ion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API design, naming conventions, etc. effort-low feature Ion Anything related to the Ion object
Projects
None yet
Development

No branches or pull requests

2 participants