Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setter for ionization fraction #326

Open
wtbarnes opened this issue Sep 30, 2024 · 0 comments · May be fixed by #337
Open

Add setter for ionization fraction #326

wtbarnes opened this issue Sep 30, 2024 · 0 comments · May be fixed by #337
Labels
API API design, naming conventions, etc. effort-low feature Ion Anything related to the Ion object
Milestone

Comments

@wtbarnes
Copy link
Owner

Similar to #325 and how the abundance is handled, there should be logic for passing in an array of ionization fractions in lieu of using the predefined dataset. By default, this would always just use those tabulated values provided by CHIANTI. There would also need to be a check that this array has the same shape as the temperature array, but this could be done in the setter.

This should be done in tandem with #324

@wtbarnes wtbarnes added effort-low feature API API design, naming conventions, etc. Ion Anything related to the Ion object labels Sep 30, 2024
@wtbarnes wtbarnes added this to the 0.4 milestone Oct 1, 2024
@jwreep jwreep linked a pull request Dec 5, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API design, naming conventions, etc. effort-low feature Ion Anything related to the Ion object
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant