Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ioneq to ionization_fraction #324

Closed
wtbarnes opened this issue Sep 30, 2024 · 0 comments · Fixed by #337
Closed

Rename ioneq to ionization_fraction #324

wtbarnes opened this issue Sep 30, 2024 · 0 comments · Fixed by #337
Labels
effort-low Ion Anything related to the Ion object
Milestone
0.4

Comments

@wtbarnes
Copy link
Owner

"ioneq" is typically used in CHIANTI to denote the ionization fraction in equilibrium and is used as the name of the property on the Ion object to represent this quantity. However, I find the name quite cryptic and not overly descriptive. This should be changed to ionization_fraction. This is straightforward to do, but should be done carefully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort-low Ion Anything related to the Ion object
Projects
None yet
Milestone
0.4
Development

Successfully merging a pull request may close this issue.

Replace ioneq with ionization_fraction and add setter jwreep/fiasco
1 participant
@wtbarnes