Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve oidc discovery integration tests #21318

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Improve oidc discovery integration tests #21318

merged 3 commits into from
Oct 15, 2024

Conversation

Thumimku
Copy link
Contributor

Public Issue : #21313

Current integration suite for oidc discovery has following issues.

  • Factory method aims to run 4 scenarios for web finger but eventually it runs oidc discovery test case for super tenant for time unnecessary.
  • Current test suite doesn't test sub tenant invalid tenant.
  • Current test suite doesn't validate popular fine grand values of the response.
  • Current test suite doesn't validate for invalid issuer.

This PR fix the above mentioned issues along with revamping the test class.

@Thumimku Thumimku mentioned this pull request Oct 10, 2024
Open
10 tasks
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11270386503

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11270386503
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11272396695

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11272396695
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11272396695

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11323987013

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11323987013
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11323987013

@Thumimku Thumimku merged commit 8546955 into wso2:master Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@asha15 asha15 asha15 approved these changes

@madurangasiriwardena madurangasiriwardena madurangasiriwardena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thumimku @jenkins-is-staging @madurangasiriwardena @asha15