Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the role basics update and role permissions update for sub organization roles #7415

Merged

Conversation

ShanChathusanda93
Copy link
Contributor

Purpose

  • $subject

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.98%. Comparing base (62a032a) to head (9b9fa85).
Report is 95 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7415   +/-   ##
=======================================
  Coverage   41.98%   41.98%           
=======================================
  Files          42       42           
  Lines         936      936           
  Branches      233      233           
=======================================
  Hits          393      393           
- Misses        499      543   +44     
+ Partials       44        0   -44     
Flag Coverage Δ
@wso2is/core 41.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@ShanChathusanda93 ShanChathusanda93 force-pushed the sub-org-role-edit-branch branch 2 times, most recently from 4038dce to 112c059 Compare January 26, 2025 21:46
pavinduLakshan
pavinduLakshan previously approved these changes Jan 27, 2025
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Copy link
Contributor

@pavinduLakshan pavinduLakshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the lint issues as well

@ShanChathusanda93
Copy link
Contributor Author

'hasRequiredScopes' import from '@wso2is/core/helpers' is restricted. Please use "import { useRequiredScopes } from '@wso2is/access-control'" instead. Refer documentation: https://github.com/wso2/identity-apps/blob/master/docs/write-code/PERFORMANCE.md#use-userequiredscopes-hook-instead-of-hasrequiredscopes-function

This PR contains only changes for allowing the edit capability for the roles which is created in the sub orgs. @brionmario is it possible to skip this for this PR?

@brionmario
Copy link
Member

'hasRequiredScopes' import from '@wso2is/core/helpers' is restricted. Please use "import { useRequiredScopes } from '@wso2is/access-control'" instead. Refer documentation: https://github.com/wso2/identity-apps/blob/master/docs/write-code/PERFORMANCE.md#use-userequiredscopes-hook-instead-of-hasrequiredscopes-function

This PR contains only changes for allowing the edit capability for the roles which is created in the sub orgs. @brionmario is it possible to skip this for this PR?

+1 to merge

@ShanChathusanda93 ShanChathusanda93 merged commit c43b146 into wso2:master Jan 30, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants