-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the role basics update and role permissions update for sub organization roles #7415
Enable the role basics update and role permissions update for sub organization roles #7415
Conversation
fdff86e
to
43f410a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7415 +/- ##
=======================================
Coverage 41.98% 41.98%
=======================================
Files 42 42
Lines 936 936
Branches 233 233
=======================================
Hits 393 393
- Misses 499 543 +44
+ Partials 44 0 -44
Flags with carried forward coverage won't be shown. Click here to find out more. |
4038dce
to
112c059
Compare
6dffbe6
to
43e849c
Compare
194efb2
to
e759588
Compare
features/admin.roles.v2/components/edit-role/edit-role-permission.tsx
Outdated
Show resolved
Hide resolved
e759588
to
9b9fa85
Compare
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix the lint issues as well
This PR contains only changes for allowing the edit capability for the roles which is created in the sub orgs. @brionmario is it possible to skip this for this PR? |
+1 to merge |
Purpose
Related Issues
Related PRs
Checklist
Security checks