Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sms template update issues in root orgs and sub orgs #7345

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

SujanSanjula96
Copy link
Contributor

@SujanSanjula96 SujanSanjula96 commented Jan 20, 2025

Purpose

Fixes SMS template update issues in root org and sub orgs. From this PR, SMS template retrieval logic is updated as follows.

  1. First get the org template directly. (This is needed to decide whether POST or PUT call needs for the update)
  2. If it is not found, inherit from parent for sub orgs and get the system template for root orgs.

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@pavinduLakshan
Copy link
Contributor

Please add changeset too.

@SujanSanjula96 SujanSanjula96 marked this pull request as draft January 21, 2025 04:28
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.04%. Comparing base (dca7d1c) to head (c73af2c).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7345   +/-   ##
=======================================
  Coverage   36.04%   36.04%           
=======================================
  Files          42       42           
  Lines         899      899           
  Branches      205      205           
=======================================
  Hits          324      324           
  Misses        575      575           
Flag Coverage Δ
@wso2is/core 36.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@SujanSanjula96 SujanSanjula96 marked this pull request as ready for review January 21, 2025 08:56
pavinduLakshan
pavinduLakshan previously approved these changes Jan 21, 2025
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@SujanSanjula96 SujanSanjula96 merged commit df262b1 into wso2:master Jan 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants