Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix change password failure for suborg users via myaccount #7278

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

SujanSanjula96
Copy link
Contributor

Purpose

This PR fixes change password failure for suborg users via myaccount. This is previously failed due to calling the scim2/Me endpoint in /t/carbon.super/ path and using username as <username>@carbon.super for basic auth for sub org users.

In order to fix this issue, this call initiated with the /t/<tenant-domain>/ path of the sub org. (Currently tenant domain of sub org equals to org ID.) Also, username given for the basic auth is also changed to <username>@<tenant-domain> for sub org users.

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@SujanSanjula96 SujanSanjula96 force-pushed the org-user-password-update branch from 7707da0 to dfc9632 Compare January 8, 2025 12:29
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.04%. Comparing base (573d6bb) to head (dc905cb).
Report is 162 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7278   +/-   ##
=======================================
  Coverage   36.04%   36.04%           
=======================================
  Files          42       42           
  Lines         899      899           
  Branches      205      222   +17     
=======================================
  Hits          324      324           
  Misses        575      575           
Flag Coverage Δ
@wso2is/core 36.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@sadilchamishka
Copy link
Contributor

This suggestion may be out of scope of this effort, but we may not need to pass the username@tenant-domain to complete the authentication. There may be BE logic which may enforce that requirement, but it shouldn't as we send tenant qualified request, the tenant domain can be derived from the context. No need to send along with an input.

@SujanSanjula96 SujanSanjula96 merged commit c277696 into wso2:master Jan 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants