-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return client error responses as structured JSON in the User Sharing API #823
Conversation
...on/identity/api/server/organization/user/sharing/management/v1/impl/UsersApiServiceImpl.java
Outdated
Show resolved
Hide resolved
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13048121047
...on/identity/api/server/organization/user/sharing/management/v1/core/UsersApiServiceCore.java
Outdated
Show resolved
Hide resolved
...on/identity/api/server/organization/user/sharing/management/v1/core/UsersApiServiceCore.java
Outdated
Show resolved
Hide resolved
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13052855765
This PR updates the User Sharing API to return client error responses in a structured JSON format instead of plain text, ensuring consistency with other API responses. Additionally, it refactors the error handling logic by moving it from
UsersApiServiceImpl
toUsersApiServiceCore
, improving maintainability and reducing redundant code.Purpose
Goals
Approach
Related Issue
product-is issue: Client error responses of user sharing API should be returned as JSON responses #22596