Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sub-organizations to update local claim mappings. #771

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Allow sub-organizations to update local claim mappings. #771

merged 4 commits into from
Jan 20, 2025

Conversation

Yasasr1
Copy link
Contributor

@Yasasr1 Yasasr1 commented Jan 8, 2025

SujanSanjula96
SujanSanjula96 previously approved these changes Jan 16, 2025
View reviewed changes
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12810288431

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12810288431
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12810469103

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12810469103
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12822014721

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12822014721
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12823406647

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12823406647
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12825304395

SujanSanjula96
SujanSanjula96 previously approved these changes Jan 17, 2025
View reviewed changes
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12825304395
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12851628272

AnuradhaSK
AnuradhaSK reviewed Jan 19, 2025
View reviewed changes
...2/carbon/identity/rest/api/server/claim/management/v1/core/ServerClaimManagementService.java Outdated
Comment on lines 1551 to 1553
String organizationId =
getOrganizationManager().resolveOrganizationId(ContextLoader.getTenantDomainFromContext());
return !getOrganizationManager().isPrimaryOrganization(organizationId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OrganizationUtils.isOrganization(ContextLoader.getTenantDomainFromContext())

could be easily used for this case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with 7bcd42b

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12851628272
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12862000606

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12862000606
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jan 20, 2025
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12862000606

@Yasasr1 Yasasr1 merged commit 7b19315 into wso2:master Jan 20, 2025
4 checks passed
@Yasasr1 Yasasr1 mentioned this pull request Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@AnuradhaSK AnuradhaSK AnuradhaSK approved these changes

@SujanSanjula96 SujanSanjula96 SujanSanjula96 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yasasr1 @jenkins-is-staging @AnuradhaSK @SujanSanjula96