Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API layer to manage authorization details types #728

Merged

Conversation

VimukthiRajapaksha
Copy link
Contributor

@VimukthiRajapaksha VimukthiRajapaksha commented Oct 29, 2024

Proposed changes in this pull request

This PR introduces modifications to enhance the management of authorization details types:

  • Updates the API Resource Management REST API to support managing authorization details types.
  • Modifies the Application Management REST API to handle authorized authorization details types.
  • Leverages service methods from the carbon-framework to manage authorization details types, including operations for persisting, validating, and retrieving these details.

Related Issues

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12946223591

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12946223591
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12946766055

Thumimku
Thumimku previously approved these changes Jan 24, 2025
@Thumimku
Copy link
Contributor

Let's bump the conflicts and check the PR builder status and merge.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12946766055
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12949266995

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12949266995
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12961700577

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12961700577
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12962881824

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12962881824
Status: failure

@Thumimku
Copy link
Contributor

product-is-surefire-report.zip

@VimukthiRajapaksha please check these test failures and state whether its related to your imporvement.

Some seems like expected because of API change, hence please check all and update.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12964372214

@VimukthiRajapaksha
Copy link
Contributor Author

VimukthiRajapaksha commented Jan 25, 2025

Hi team,

Requesting to approve the PR as previously failing tests are now passing when run locally. I've attached a screenshot and logs for reference. Just a heads-up: once this is merged, the product-is might fail since it depends on PR wso2/product-is#21703.

surefire-reports.zip

Screenshot 2025-01-25 at 7 12 03 PM

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12964372214
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12966157366

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12966157366
Status: failure

@Thumimku
Copy link
Contributor

Hi team,

Requesting to approve the PR as previously failing tests are now passing when run locally. I've attached a screenshot and logs for reference. Just a heads-up: once this is merged, the product-is might fail since it depends on PR wso2/product-is#21703.

surefire-reports.zip

Screenshot 2025-01-25 at 7 12 03 PM

Based on this comment I am approving the request

@Thumimku Thumimku merged commit 0ba8be5 into wso2:master Jan 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants