-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API resources and access control for user share API. #6373
Conversation
...y-core/org.wso2.carbon.identity.core.server.feature/resources/resource-access-control-v2.xml
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6373 +/- ##
============================================
+ Coverage 46.36% 46.54% +0.17%
- Complexity 14770 14840 +70
============================================
Files 1714 1723 +9
Lines 103938 104066 +128
Branches 18630 18619 -11
============================================
+ Hits 48195 48433 +238
+ Misses 48852 48737 -115
- Partials 6891 6896 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c50f509
to
1d152a9
Compare
@@ -917,6 +917,30 @@ | |||
description="Introspect tokens"/> | |||
</Scopes> | |||
</APIResource> | |||
<APIResource name="User Share API" identifier="/api/server/v1/users" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<APIResource name="User Share API" identifier="/api/server/v1/users" | |
<APIResource name="User Sharing API" identifier="/api/server/v1/users" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BimsaraBodaragama let's update the API definition from a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update other places as well
1d152a9
to
0a31bd4
Compare
Quality Gate passedIssues Measures |
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12984912065
Purpose
$subject
Related pr
Related issue