Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to return valid name id format #6256

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

SujanSanjula96
Copy link
Contributor

Proposed changes in this pull request

$Subject to fix the inconsistency in API response regarding the SAML name ID format.

Issue -wso2/product-is#21826

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12622471719

Copy link

sonarqubecloud bot commented Jan 5, 2025

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.62%. Comparing base (705a08e) to head (4b6a568).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6256      +/-   ##
============================================
+ Coverage     45.48%   45.62%   +0.13%     
+ Complexity    14185    14127      -58     
============================================
  Files          1633     1633              
  Lines        101514   101444      -70     
  Branches      17982    17869     -113     
============================================
+ Hits          46177    46281     +104     
+ Misses        48571    48427     -144     
+ Partials       6766     6736      -30     
Flag Coverage Δ
unit 28.47% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12622471719
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12622471719

@SujanSanjula96 SujanSanjula96 merged commit 54c1218 into wso2:master Jan 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants