Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SharedProfileValueResolvingMethod validation on local claim addition #6255

Conversation

AnuradhaSK
Copy link
Contributor

Proposed changes in this pull request

  • If SharedProfileValueResolvingMethod claim property is specified during local claim addition, it should be matched to one of the enums of follows:
  1. FromOrigin
  2. FromSharedProfile
  3. FromFirstFoundInHierarchy

When should this PR be merged

N/A

Copy link

sonarqubecloud bot commented Jan 4, 2025

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.62%. Comparing base (add14de) to head (dba0f4f).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6255   +/-   ##
=========================================
  Coverage     45.62%   45.62%           
+ Complexity    14159    14127   -32     
=========================================
  Files          1633     1633           
  Lines        101439   101444    +5     
  Branches      17928    17869   -59     
=========================================
+ Hits          46277    46281    +4     
  Misses        48427    48427           
- Partials       6735     6736    +1     
Flag Coverage Δ
unit 28.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12620028649

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12620028649
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12620028649

@AnuradhaSK AnuradhaSK merged commit e1eea14 into wso2:master Jan 5, 2025
4 checks passed
@AnuradhaSK AnuradhaSK deleted the add-SharedProfileValueResolvingMethod-method-validation branch January 5, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants