Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate SharedProfileValueResolvingMethod change on claim update #6247

Merged

Conversation

AnuradhaSK
Copy link
Contributor

@AnuradhaSK AnuradhaSK commented Jan 1, 2025

Proposed changes in this pull request

  • Validate SharedProfileValueResolvingMethod change on local claim update
If the updating local claim is a system claim -> Can't change the value other than a value equal to the system default property value. However, the property can be removed. 
If the updating local claim is a non system claim -> Updating value should be matched to define enum's name

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.72%. Comparing base (4fbd3f6) to head (9148662).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...tadata/mgt/ClaimMetadataManagementServiceImpl.java 96.96% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6247      +/-   ##
============================================
+ Coverage     45.56%   45.72%   +0.15%     
+ Complexity    14112    14065      -47     
============================================
  Files          1633     1633              
  Lines        101071   100705     -366     
  Branches      17700    17706       +6     
============================================
- Hits          46058    46045      -13     
+ Misses        48298    47959     -339     
+ Partials       6715     6701      -14     
Flag Coverage Δ
unit 28.46% <97.87%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12572633471

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12572633471
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12572633471

@AnuradhaSK AnuradhaSK force-pushed the validate-resolver-method-on-claim-update branch from 345247a to f3083f2 Compare January 2, 2025 10:16
@AnuradhaSK AnuradhaSK force-pushed the validate-resolver-method-on-claim-update branch from 0f10806 to 9148662 Compare January 3, 2025 05:23
Copy link

sonarqubecloud bot commented Jan 3, 2025

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12593925162

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12593925162
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12595720352

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12595720352
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12595720352

@AnuradhaSK AnuradhaSK merged commit 1ac7391 into wso2:master Jan 3, 2025
5 checks passed
@AnuradhaSK AnuradhaSK deleted the validate-resolver-method-on-claim-update branch January 4, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants