Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SharedProfileValueResolvingMethod meta data to local claims #6246

Merged

Conversation

AnuradhaSK
Copy link
Contributor

@AnuradhaSK AnuradhaSK commented Jan 1, 2025

Proposed changes in this pull request

Based on the behavior of each claim, define a value for SharedProfileValueResolvingMethod metadata out of:

@AnuradhaSK AnuradhaSK changed the title add SharedProfileValueResolvingMethod meta data to local claims Add SharedProfileValueResolvingMethod meta data to local claims Jan 1, 2025
Copy link

sonarqubecloud bot commented Jan 1, 2025

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (f70492e) to head (d3dfdff).
Report is 366 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master    #6246    +/-   ##
==========================================
  Coverage     45.69%   45.70%            
+ Complexity    14078    14059    -19     
==========================================
  Files          1633     1633            
  Lines        100914   100656   -258     
  Branches      17730    17696    -34     
==========================================
- Hits          46117    46004   -113     
+ Misses        48080    47956   -124     
+ Partials       6717     6696    -21     
Flag Coverage Δ
unit 28.40% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

~ specific language governing permissions and limitations
~ under the License.
-->
~ Copyright (c) 2005-2025, WSO2 LLC. (http://www.wso2.com).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
~ Copyright (c) 2005-2025, WSO2 LLC. (http://www.wso2.com).
~ Copyright (c) 2005-2025, WSO2 LLC. (http://www.wso2.com).

Seems like unintended formatting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added license format is generated via the IDE and the correct formatting is to have two space indentation from the left corner.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12908993296

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12908993296
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12908993296

@AnuradhaSK AnuradhaSK merged commit 553f668 into wso2:master Jan 22, 2025
5 checks passed
@AnuradhaSK AnuradhaSK deleted the add-SharedProfileValueResolvingMethod branch January 24, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants