Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Child Org Notification Template Overriding Capability #6187

Merged

Conversation

dhaura
Copy link
Contributor

@dhaura dhaura commented Dec 9, 2024

Purpose

  • $Subject
  • The following scopes are introduced in Notification and Email template management APIs in order to enable child org overriding capabilities in notification templates.
    • Email v1/ v2 API
      • POST /o/api/server/v(.*)/email/template-types - internal_org_email_mgt_create
      • PUT /o/api/server/v(.*)/email/template-types - internal_org_email_mgt_update
      • DELETE /o/api/server/v(.*)/email/template-types - internal_org_email_mgt_delete
    • Notification API
      • POST /o/api/server/v(.*)/notification/(?:email|sms)/template-type - internal_org_template_mgt_create
      • PUT /o/api/server/v(.*)/notification/(?:email|sms)/template-type - internal_org_template_mgt_update
      • DELETE /o/api/server/v(.*)/notification/(?:email|sms)/template-type - internal_org_template_mgt_delete

Related Issues

Copy link

sonarqubecloud bot commented Dec 9, 2024

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.32%. Comparing base (37745ca) to head (3f863e9).
Report is 392 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6187      +/-   ##
============================================
- Coverage     45.33%   45.32%   -0.01%     
+ Complexity    13832    13819      -13     
============================================
  Files          1614     1614              
  Lines         99700    99700              
  Branches      16833    16833              
============================================
- Hits          45196    45188       -8     
- Misses        47860    47868       +8     
  Partials       6644     6644              
Flag Coverage Δ
unit 27.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SujanSanjula96 SujanSanjula96 marked this pull request as ready for review January 10, 2025 07:40
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12705768010

<Scope displayName="View Email Template" name="internal_org_email_mgt_view"
description="View email templates and types in the organization"/>
<Scope displayName="Create Email Template" name="internal_org_email_mgt_create"
description="Create new email template and types in the organization"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description="Create new email template and types in the organization"/>
description="Create new email templates and types in the organization"/>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in a separate PR.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12705768010
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12705947048

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12705947048
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12705947048

@SujanSanjula96 SujanSanjula96 merged commit d43e61d into wso2:master Jan 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants