-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a post authenticaton handler to validate email domain during federated authentication #6177
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6177 +/- ##
============================================
+ Coverage 45.83% 46.26% +0.42%
+ Complexity 15127 15072 -55
============================================
Files 1736 1729 -7
Lines 107598 106789 -809
Branches 19666 18958 -708
============================================
+ Hits 49320 49406 +86
+ Misses 51246 50342 -904
- Partials 7032 7041 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b25fbc7
to
f2d9736
Compare
f2d9736
to
f5cda0f
Compare
.../application/authentication/framework/handler/request/impl/EmailDomainValidationHandler.java
Outdated
Show resolved
Hide resolved
.../application/authentication/framework/handler/request/impl/EmailDomainValidationHandler.java
Outdated
Show resolved
Hide resolved
.../application/authentication/framework/handler/request/impl/EmailDomainValidationHandler.java
Outdated
Show resolved
Hide resolved
.../application/authentication/framework/handler/request/impl/EmailDomainValidationHandler.java
Outdated
Show resolved
Hide resolved
.../application/authentication/framework/handler/request/impl/EmailDomainValidationHandler.java
Show resolved
Hide resolved
.../application/authentication/framework/handler/request/impl/EmailDomainValidationHandler.java
Outdated
Show resolved
Hide resolved
.../application/authentication/framework/handler/request/impl/EmailDomainValidationHandler.java
Outdated
Show resolved
Hide resolved
...lication/authentication/framework/handler/request/impl/EmailDomainValidationHandlerTest.java
Outdated
Show resolved
Hide resolved
...lication/authentication/framework/handler/request/impl/EmailDomainValidationHandlerTest.java
Outdated
Show resolved
Hide resolved
.../java/org/wso2/carbon/identity/application/authentication/framework/util/FrameworkUtils.java
Outdated
Show resolved
Hide resolved
All above comments are addressed with a338dc7 |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12822007199
.../application/authentication/framework/handler/request/impl/EmailDomainValidationHandler.java
Outdated
Show resolved
Hide resolved
.../application/authentication/framework/handler/request/impl/EmailDomainValidationHandler.java
Outdated
Show resolved
Hide resolved
.../application/authentication/framework/handler/request/impl/EmailDomainValidationHandler.java
Outdated
Show resolved
Hide resolved
.../application/authentication/framework/handler/request/impl/EmailDomainValidationHandler.java
Outdated
Show resolved
Hide resolved
.../application/authentication/framework/handler/request/impl/EmailDomainValidationHandler.java
Outdated
Show resolved
Hide resolved
...arbon/identity/application/authentication/framework/internal/FrameworkServiceDataHolder.java
Outdated
Show resolved
Hide resolved
...arbon/identity/application/authentication/framework/internal/FrameworkServiceDataHolder.java
Outdated
Show resolved
Hide resolved
...lication/authentication/framework/handler/request/impl/EmailDomainValidationHandlerTest.java
Outdated
Show resolved
Hide resolved
...ity/application/authentication/framework/handler/request/impl/email-domain-validation-sp.xml
Outdated
Show resolved
Hide resolved
...lication/authentication/framework/handler/request/impl/EmailDomainValidationHandlerTest.java
Outdated
Show resolved
Hide resolved
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
PR builder started |
Quality Gate passedIssues Measures |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12984901106
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12986542130
Proposed changes in this pull request
This pr introduces a new post authentication handler to validate the email address of the user authenticated from a federated IDP.
This handler will be invoked when email domain based organization discovery is enabled to prevent user authentication and provisioning to organizations when the authenticated user's email domain does not match with any of the mapped email domains for the organization.
Related issue