Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username recovery sms support #6040

Merged
merged 25 commits into from
Nov 15, 2024

Conversation

Malith-19
Copy link
Contributor

@Malith-19 Malith-19 commented Oct 18, 2024

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 48.33333% with 31 lines in your changes missing coverage. Please review.

Project coverage is 25.59%. Comparing base (3f9afca) to head (4e9afb9).
Report is 96 commits behind head on master.

Files with missing lines Patch % Lines
.../org/wso2/carbon/idp/mgt/dao/IdPManagementDAO.java 8.82% 27 Missing and 4 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #6040       +/-   ##
=============================================
- Coverage     40.94%   25.59%   -15.36%     
+ Complexity    14607     7063     -7544     
=============================================
  Files          1767     1601      -166     
  Lines        118050   100729    -17321     
  Branches      19169    15357     -3812     
=============================================
- Hits          48339    25783    -22556     
- Misses        62426    71389     +8963     
+ Partials       7285     3557     -3728     
Flag Coverage Δ
conformance-fapi ?
conformance-oidc ?
integration ?
unit 25.59% <48.33%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Malith-19
Copy link
Contributor Author

Quality Gate Failed Quality Gate failed

Failed conditions B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

This is because we are using API paths as final strings in the recoveryApiV2 class.

sadilchamishka
sadilchamishka previously approved these changes Oct 28, 2024
@Malith-19 Malith-19 self-assigned this Oct 29, 2024
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11737474028

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11737474028
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11737625202

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11737625202
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11739773714

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11739773714
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11775811717

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11775811717
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11816884316

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11816884316
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11831233288

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11831233288
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11851776770

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11851776770
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11851776770

@ashensw ashensw merged commit 3ef6d94 into wso2:master Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants