-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Changes for ApiKey support #73
Open
malithiperera
wants to merge
3
commits into
wso2-extensions:feature-workflow-externalization
Choose a base branch
from
malithiperera:api-key-ui-support
base: feature-workflow-externalization
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
UI Changes for ApiKey support #73
malithiperera
wants to merge
3
commits into
wso2-extensions:feature-workflow-externalization
from
malithiperera:api-key-ui-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malithiperera
force-pushed
the
api-key-ui-support
branch
from
April 24, 2023 07:13
916d260
to
73714ae
Compare
dewniMW
reviewed
May 4, 2023
Comment on lines
+46
to
+48
//if (!doValidateForm(formElement, "<fmt:message key="error.input.validation.error"/>")) { | ||
// return false; | ||
//} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this commented?
dewniMW
reviewed
May 4, 2023
@@ -396,4 +396,4 @@ | |||
<http:address location="https://localhost:9443/services/WorkflowImplAdminService.WorkflowImplAdminServiceHttpsEndpoint/"/> | |||
</wsdl:port> | |||
</wsdl:service> | |||
</wsdl:definitions> | |||
</wsdl:definitions> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end the file with a new line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new UI change has been introduced to provide an API Key, which is necessary for deploying the workflow service mediator in Choreo.
Currently, the UI only allows for adding BPS profile details. However, with the introduction of an external workflow service mediator, it becomes necessary to include an API Key. To address this requirement, a new section has been introduced to provide the API Key based on the type of profile.
When should this PR be merged
[Please describe any preconditions that need to be addressed before we
can merge this pull request.]
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation