Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added multiOptionURI parameter to the redirect url in the magic-link authenticator #46

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Added multiOptionURI parameter to the redirect url in the magic-link authenticator #46

merged 3 commits into from
Jan 18, 2024

Conversation

ashanthamara
Copy link
Contributor

@ashanthamara ashanthamara commented Nov 24, 2023 •
edited
Loading

#Purpose

$subject
With this PR, the multiOptionURI parameter will be sent to the identifierauth.jsp and with that it will show the Choose a different option link which is allowing the user to go back to other authenticators in the respective authentication step.

Related Issue

@ashanthamara
Copy link
Contributor Author

Currently there is a issue in the Magic Link authenticator for as described in wso2/product-is#18075.
Merging this PR, will show the Choose a different authenticator link in the UI. That will increase the possibility of occurring the above mentioned issue.
Hence not merging this PR, until the issue is fixed.

@ashanthamara ashanthamara mentioned this pull request Nov 24, 2023
Closed
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7569684480

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7569684480
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7570210920

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7570210920
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jan 18, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7570210920

@madurangasiriwardena madurangasiriwardena merged commit 95e9517 into wso2-extensions:main Jan 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdeshAthukorala UdeshAthukorala UdeshAthukorala left review comments

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@madurangasiriwardena madurangasiriwardena madurangasiriwardena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashanthamara @jenkins-is-staging @madurangasiriwardena @UdeshAthukorala