-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the group last modified date when updating a group [when unique group id is disabled] #590
base: master
Are you sure you want to change the base?
Update the group last modified date when updating a group [when unique group id is disabled] #590
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #590 +/- ##
============================================
+ Coverage 44.46% 46.44% +1.97%
+ Complexity 1035 993 -42
============================================
Files 41 41
Lines 8941 8974 +33
Branches 1925 1926 +1
============================================
+ Hits 3976 4168 +192
+ Misses 4090 3895 -195
- Partials 875 911 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12593838234
2117b8a
to
4bf052b
Compare
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12596878387
fd40eff
to
ce44f1c
Compare
ce44f1c
to
9b28e2a
Compare
Purpose
When a group is modified by renaming it's display name, adding a user to the group or removing an user from the group, the group last modified date needs to be updated. This PR fixes that issue by updating the group last modified date on such scenarios.
Note: The SCIM level update is only required when the group unique id feature is disabled. Otherwise the attributes will be stored in the user store.
Goals
Update the group modified time when adding/ removing a user to/ from a group.
Related Issue
Related PRs