Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the group last modified date when updating a group [when unique group id is disabled] #590

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ThaminduDilshan
Copy link

@ThaminduDilshan ThaminduDilshan commented Jan 3, 2025

Purpose

When a group is modified by renaming it's display name, adding a user to the group or removing an user from the group, the group last modified date needs to be updated. This PR fixes that issue by updating the group last modified date on such scenarios.

Note: The SCIM level update is only required when the group unique id feature is disabled. Otherwise the attributes will be stored in the user store.

Goals

Update the group modified time when adding/ removing a user to/ from a group.

Related Issue

Related PRs

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.44%. Comparing base (c457f30) to head (9b28e2a).

Files with missing lines Patch % Lines
...on/identity/scim2/common/impl/SCIMUserManager.java 96.55% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #590      +/-   ##
============================================
+ Coverage     44.46%   46.44%   +1.97%     
+ Complexity     1035      993      -42     
============================================
  Files            41       41              
  Lines          8941     8974      +33     
  Branches       1925     1926       +1     
============================================
+ Hits           3976     4168     +192     
+ Misses         4090     3895     -195     
- Partials        875      911      +36     
Flag Coverage Δ
unit 31.32% <97.56%> (+2.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12593838234

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12593838234
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12593838234

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12596878387

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12596878387
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12596878387

@ThaminduDilshan ThaminduDilshan force-pushed the thamindu-last-modified branch 2 times, most recently from fd40eff to ce44f1c Compare January 3, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants