Cursor based pagination for SCIM resources effort 2 #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r pagination is supported
Cursor pagination changes phase 1 formatting adjustments before PR Few changes after the code review Changes suggested in the code review Changed strings into constants Changing the response type from a List to UsersGetResponse type object Changes to support pagination with POST/.Search. Group filtering changes. Changes to SingleAttribute and MultiAttribute filtering to properly create the UsersGetResponse. Removing commented code Made changes for the ServiceProviderConfigEndpoint to show that cursor pagination is supported Wording updates to the ServiceProviderConfigEndpoint changes Making changes so that cursor pagination uses PRIMARY domain when a domain is not specified Removing unused parameters Adjusting the test cases broken due to changes made and introductig new test cases for the new flows Adding punctuation to the comments
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to get the initial phase of cursor pagination for SCIM resource listings working with the Identity Server in JDBC and LDAP user stores.
Goals
Related Issues
Related PRs