Improve cleaning issued tokens of an organization user when user is deleting

[ShanChathusanda93]

Proposed changes in this pull request

• $subject

[codecov]

Codecov Report

Attention: Patch coverage is 29.23077% with 46 lines in your changes missing coverage. Please review.

Project coverage is 56.55%. Comparing base (4e516a5) to head (34e46de).

Files with missing lines	Patch %	Lines
...java/org/wso2/carbon/identity/oauth/OAuthUtil.java	29.23%	42 Missing and 4 partials ⚠️

❌ Your patch check has failed because the patch coverage (29.23%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2680      +/-   ##
============================================
+ Coverage     56.17%   56.55%   +0.37%     
+ Complexity     8633     8500     -133     
============================================
  Files           654      654              
  Lines         49129    48268     -861     
  Branches       9817     9648     -169     
============================================
- Hits          27598    27297     -301     
+ Misses        17586    17095     -491     
+ Partials       3945     3876      -69     

Flag	Coverage Δ
unit	39.49% <29.23%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SujanSanjula96]

Are we sure whether removing this code will not affect existing flows by chance?

[ShanChathusanda93]

This was added to cater the SSO flow token revokation. Before calling the toke revoke method the user id will be added as the username from the following code from the OAuthUtil -> revokeTokens method.

if (authenticatedUser.getUserResidentOrganization() != null) {
            try {
                userResidentTenant = OAuthComponentServiceHolder.getInstance().getOrganizationManager()
                        .resolveTenantDomain(authenticatedUser.getUserResidentOrganization());
                if (OrganizationManagementUtil.isOrganization(userResidentTenant)) {
                    authenticatedUserName = authenticatedUser.getUserName();
                    authenticatedUser.setUserName(authenticatedUser.getUserId());
                }
            } catch (OrganizationManagementException | UserIdNotFoundException e) {
                throw new UserStoreException("Error occurred while constructing the authenticated user.", e);
            }
        }

[AnuradhaSK]

Why authenticatedUser.getUserResidentOrganization() != null logic is separately handled in 1098 and 1081 lines?
Can't we handled these in a single if block?

[AnuradhaSK]

Login a sub org user into a B2B app and swicthing to another below sub org can also set a sub org as userResidentTenant
Have you tested that as well?

If the flow I mentioned is handling from here, the added comment is wrong.

[ShanChathusanda93]

Updated the logic

[jenkins-is-staging]

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13040323314

[jenkins-is-staging]

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13040323314
Status: failure