Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DCR PUT request not updating application role audience #2649

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

ThaminduR
Copy link
Contributor

This PR fixes an issue in the DCR PUT implementation where the application role audience value was not persisted to the database.

Changes

  • Added logic to store the application role audience during DCR updates.
  • Improved unit tests to validate the application role audience update.

Issue

wso2/product-is#21627

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12348463942

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.49%. Comparing base (4953794) to head (6d7e4e8).
Report is 59 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2649      +/-   ##
============================================
- Coverage     56.54%   56.49%   -0.05%     
+ Complexity     8261     8192      -69     
============================================
  Files           632      632              
  Lines         46690    46344     -346     
  Branches       8355     8349       -6     
============================================
- Hits          26402    26184     -218     
+ Misses        16580    16442     -138     
- Partials       3708     3718      +10     
Flag Coverage Δ
unit 38.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12348463942
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12366024205

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12366024205
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12370501328

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12370501328
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12370501328

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12647430603

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12647430603
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12647430603

@ThaminduR ThaminduR merged commit 8ae348e into wso2-extensions:master Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants