Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the password reset authentication handler and convert last password update time to correct format #898

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sandushi
Copy link
Contributor

@sandushi sandushi commented Jan 2, 2025

Proposed changes in this pull request

$subject

Changes from this PR

There are two main changes are done by this PR :

  1. Skip the password reset post authentication handler when password reset enforcer set as an authentictor.
    • The password reset authenticator handler is skipped when the password reset enforcer authenticator is engaged in the authentication flows.
    • This is done because the password expiry is already checked by password reset enforcer authenticator.
  2. Convert the last password update time to correct format when active directory is setup as the user store.

Related issue

wso2/product-is#21890

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 50.77%. Comparing base (55bf5a4) to head (ccc6275).

Files with missing lines Patch % Lines
...tity/password/expiry/util/PasswordPolicyUtils.java 30.00% 6 Missing and 1 partial ⚠️
...iry/EnforcePasswordResetAuthenticationHandler.java 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #898      +/-   ##
============================================
+ Coverage     50.56%   50.77%   +0.20%     
+ Complexity     2427     2422       -5     
============================================
  Files           298      298              
  Lines         17979    18138     +159     
  Branches       2584     2578       -6     
============================================
+ Hits           9091     9209     +118     
- Misses         7743     7774      +31     
- Partials       1145     1155      +10     
Flag Coverage Δ
unit 38.55% <40.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12578819894

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12578819894
Status: failure

kayathiri4
kayathiri4 previously approved these changes Jan 3, 2025
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12578819894

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12578819894
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12578819894

@sandushi sandushi changed the title Skip the password reset authentication handler when password reset enforcer authenticator in the authenticators list Skip the password reset authentication handler and convert last password update time to correct format Jan 3, 2025
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12618787589

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12618787589
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12618787589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants