Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls Tutorial for Motion Profiling #2589

Merged
merged 32 commits into from
Jan 5, 2025

Conversation

gerth2
Copy link
Contributor

@gerth2 gerth2 commented Mar 1, 2024

Using vertical elevator as the driving example for now

Entering draft PR for comments.

Will update as functionality is added

@gerth2
Copy link
Contributor Author

gerth2 commented Mar 8, 2024

Question for the group.

TrapezoidProfile from wpimath (or something similar) is needed to complete this PR.

Two options for how to generate it without blowing up scope:

  1. rewrite by hand in .js
  2. Use something like https://www.codeconvert.ai/app to auto-convert with some fixup.

AI code ownership can be fraught in a corporate context, but I'm not sure how much that applies in open source. Thoughts on the risk before we move forward with 2 over 1? I'm fine with either.

Note, as mentioned in the past, a nifty thing would be a webasm build of wpimath that we build these sims around. But that's still a longer lead-time item.

@gerth2 gerth2 marked this pull request as ready for review March 8, 2024 05:24
@sciencewhiz
Copy link
Collaborator

Two options for how to generate it without blowing up scope:

1. rewrite by hand in .js

2. Use something like https://www.codeconvert.ai/app to auto-convert with some fixup.

Or #1831

@gerth2
Copy link
Contributor Author

gerth2 commented Oct 8, 2024

In an attempt to not let this rot too much...

If 1831 doesn't have line of sight to get solved prior to 2025 season, would going back on the initial two options be acceptable?

@gerth2 gerth2 force-pushed the gerth2_elevator_motion_profiling branch from 3a2becc to 49d309c Compare December 19, 2024 18:54
@gerth2 gerth2 force-pushed the gerth2_elevator_motion_profiling branch from 49d309c to f1c2556 Compare December 19, 2024 20:37
@gerth2
Copy link
Contributor Author

gerth2 commented Dec 19, 2024

rewritten sans AI.

@gerth2 gerth2 force-pushed the gerth2_elevator_motion_profiling branch from ced518f to 3a3adf9 Compare January 2, 2025 17:50
Copy link
Member

@jasondaming jasondaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also modify the "Introduction To Controls Tuning Tutorials" to reference the 4 (it says 3 at top) tutorials and link to this tutorial in the list of that last paragraph.

@jasondaming
Copy link
Member

Did you choose not to add the link in the last intro paragraph? That is fine if you don't want it in there but seems like it would go well

@jasondaming jasondaming merged commit ade4816 into wpilibsuite:main Jan 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants