Tangle elements changing data- attributes based on changing values #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we're big fans of Tangle @ my company, but we ran into an issue when trying to limit one element based on another. Changing the data-max variable did nothing, as Tangle takes the attributes at initialization and then never looks at them again.
So I took some code from your getOptionsForElement function and dropped it into the touchDidMove function of the TKAdjustableNumber class. I'm still something of a js newb, so I wasn't sure how to just call the gOFE function from there.
But this was how I fixed it, allowing data- attributes to change after inititialization (and even within one click, -format being the main application that I can think of).
Thanks for a great library!