Add an HasEndpoint instance for AuthProtect #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, is there a reason Servant is constrained to < 0.20 ? |
|
@vendethiel
Most likely it will work well with 0.20, if you need that - we can move upper bound and add a support for higher ghc version |
Work codebase is not dependent on newer Servant, so it's not a priority, I just wanted to know. |
worm2fed
force-pushed
the
add-authprotect-instance
branch
from
5758335 to
3b9a656
Compare
|
@vendethiel you're welcome to merge |
|
I don't think I can merge PRs here |
|
Thank you! |
worm2fed
added a commit
that referenced
this pull request
Dec 15, 2023
Change was introduced in #5, but I've missed changelog entry.
worm2fed
added a commit
that referenced
this pull request
Dec 15, 2023
* doc: add missing changelog entry Change was introduced in #5, but I've missed changelog entry. * Prepare release 1.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the package. It was just missing this instance which we use.