Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(update-agent): publishing update-agent progress to dbus #349

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sfikastheo
Copy link
Contributor

@sfikastheo sfikastheo commented Jan 13, 2025

  • orb_update_agent_dbus crate adds a dbus interface and proxy for sharing update-progress.
  • Changes to the orb_update_agentcrate for publishing the update progress to dbus (Best effort approach following the already archetype in the update-agent).

@sfikastheo sfikastheo requested a review from TheButlah January 13, 2025 13:55
Copy link
Collaborator

@TheButlah TheButlah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! just a few small tweaks and we will be done :)

update-agent/dbus/src/lib.rs Outdated Show resolved Hide resolved
update-agent/src/dbus/interfaces.rs Outdated Show resolved Hide resolved
update-agent/src/main.rs Outdated Show resolved Hide resolved
update-agent/dbus/src/lib.rs Outdated Show resolved Hide resolved
update-agent/src/main.rs Outdated Show resolved Hide resolved
update-agent/src/dbus/interfaces.rs Outdated Show resolved Hide resolved
update-agent/src/dbus/interfaces.rs Outdated Show resolved Hide resolved
update-agent/dbus/src/lib.rs Outdated Show resolved Hide resolved
update-agent/dbus/src/lib.rs Outdated Show resolved Hide resolved
update-agent/dbus/src/lib.rs Show resolved Hide resolved
update-agent/src/main.rs Show resolved Hide resolved
@sfikastheo sfikastheo requested a review from TheButlah January 16, 2025 20:34
@sfikastheo sfikastheo force-pushed the sfikas/update-agent-progress branch from 4e3f071 to b3564fe Compare January 25, 2025 21:19
@sfikastheo sfikastheo force-pushed the sfikas/update-agent-progress branch from b3564fe to bd4f1c3 Compare January 25, 2025 23:32
Copy link
Collaborator

@TheButlah TheButlah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very close to done. just a few small tweaks and we are good to go. Thanks!

update-agent/dbus/src/lib.rs Show resolved Hide resolved
update-agent/dbus/src/lib.rs Show resolved Hide resolved
update-agent/src/component.rs Outdated Show resolved Hide resolved
update-agent/src/dbus/interfaces.rs Outdated Show resolved Hide resolved
update-agent/src/dbus/interfaces.rs Outdated Show resolved Hide resolved
update-agent/src/main.rs Outdated Show resolved Hide resolved
update-agent/src/main.rs Show resolved Hide resolved
@sfikastheo sfikastheo requested a review from TheButlah January 27, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants