attest: break dbus into separate crate #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
force-pushed
the
ryanbutler-orbp-255-orb-attest-break-out-dbus-into-crate
branch
from
ee0b686 to
7cc68ca
Compare
TheButlah
changed the title
TheButlah
changed the title
TheButlah
force-pushed
the
ryanbutler-orbp-255-orb-attest-break-out-dbus-into-crate
branch
from
7cc68ca to
494ecbd
Compare
TheButlah
changed the title
TheButlah
changed the title
TheButlah
changed the title
TheButlah
changed the title
Qbicz
reviewed
Sep 25, 2024
TheButlah
force-pushed
the
ryanbutler-orbp-255-orb-attest-break-out-dbus-into-crate
branch
from
494ecbd to
42e71a3
Compare
vmenge
approved these changes
Sep 25, 2024
TheButlah
changed the title
TheButlah
changed the title
TheButlah
deleted the
ryanbutler-orbp-255-orb-attest-break-out-dbus-into-crate
branch
vmenge
added a commit
that referenced
this pull request
Oct 1, 2024
* chore(orb-slot-ctrl): codeowners * refactor(orb-slot-ctrl): use EfiVarDb for testability * tests(orb-slot-ctrl): integration tests * chore(orb-slot-ctrl): make clippy happy * chore(update-verifier): use latest version of orb-slot-ctrl * chore(orb-slot-ctrl): remove unused imports on test * refactor: use zbus 4, migrate from deprecated macros (#227) * attest: break dbus into separate crate (#229) attest: break dbus into crate * orb-qr-link: Support UUID for orb-relay comms (#243) * orb-ui: queue sound with an initial delay (#237) delay is awaited until elapsed before playing the sound. * tests(orb-slot-ctrl): integration tests * chore(orb-slot-ctrl): macos pipeline... * chore(orb-slot-ctrl): remove unused imports * chore: remove codeowners line * chore(update-verifier): bootstrap dependencies on main.rs * chore(orb-slot-ctrl): macos as unspported target * chore(orb-slot-ctrl): more explicit test-util fixture init --------- Co-authored-by: Ryan Butler <[email protected]> Co-authored-by: Anastasios Andronidis <[email protected]> Co-authored-by: Cyril Fougeray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on #227
This PR breaks the dbus proxy and interface of orb-attest into a separate crate, and deletes all other copy-pastad zbus::proxy definitions for orb-attest.
This also paves the way to mock orb-attest if we need to in tests.
I intend to repeat this same pattern for all the other dbus interfaces, if reviews are favorable.