fix must_use

attest/src/main.rs

@@ -1,7 +1,7 @@
 #[tokio::main]
 async fn main() -> color_eyre::Result<()> {
     color_eyre::install()?;
-    orb_telemetry::TelemetryConfig::new()
+    let _telemetry_guard = orb_telemetry::TelemetryConfig::new()
         .with_journald(orb_attest::SYSLOG_IDENTIFIER)
         .init();
     orb_attest::main().await

attest/src/remote_api.rs

@@ -518,7 +518,7 @@ printf dmFsaWRzaWduYXR1cmU=
     // A happy path
     #[tokio::test]
     async fn get_token() {
-        orb_telemetry::TelemetryConfig::new().init();
+        let _telemetry_guard = orb_telemetry::TelemetryConfig::new().init();
 
         let mock_server = MockServer::start().await;
 

backend-state/src/main.rs

@@ -32,11 +32,11 @@ const SYSLOG_IDENTIFIER: &str = "worldcoin-backend-state";
 #[command(about, author, version=BUILD_INFO.version, styles=make_clap_v3_styles())]
 struct Cli {}
 
-// No need to waste RAM with a threadpool.
-#[tokio::main(flavor = "current_thread")]
+// No need to waste RAM with a ton of threads, but we need at least 1 for telemetry.
+#[tokio::main(flavor = "multi_thread", worker_threads = 1)]
 async fn main() -> Result<()> {
     color_eyre::install()?;
-    orb_telemetry::TelemetryConfig::new()
+    let _telemetry_guard = orb_telemetry::TelemetryConfig::new()
         .with_journald(SYSLOG_IDENTIFIER)
         .init();
 

experiments/zenoh/src/main.rs

@@ -17,7 +17,7 @@ enum Args {
 
 #[tokio::main]
 async fn main() -> color_eyre::Result<()> {
-    orb_telemetry::TelemetryConfig::new().init();
+    let _telemetry_guard = orb_telemetry::TelemetryConfig::new().init();
     tracing::debug!("debug logging is enabled");
 
     let args = Args::parse();

mcu-util/src/main.rs

@@ -267,7 +267,7 @@ fn clap_v3_styles() -> Styles {
 #[tokio::main]
 async fn main() -> Result<()> {
     color_eyre::install()?;
-    orb_telemetry::TelemetryConfig::new().init();
+    let _telemetry_guard = orb_telemetry::TelemetryConfig::new().init();
 
     let args = Args::parse();
 

supervisor/src/main.rs

@@ -30,7 +30,7 @@ fn clap_v3_styles() -> Styles {
 #[tokio::main]
 async fn main() -> color_eyre::Result<()> {
     color_eyre::install()?;
-    orb_telemetry::TelemetryConfig::new()
+    let _telemetry_guard = orb_telemetry::TelemetryConfig::new()
         .with_journald(SYSLOG_IDENTIFIER)
         .init();
     debug!("initialized telemetry");

supervisor/tests/it/helpers.rs

@@ -11,7 +11,7 @@ use zbus::{
 pub const WORLDCOIN_CORE_SERVICE_OBJECT_PATH: &str =
     "/org/freedesktop/systemd1/unit/worldcoin_2dcore_2eservice";
 static TRACING: Lazy<()> = Lazy::new(|| {
-    orb_telemetry::TelemetryConfig::new().init();
+    let _ = orb_telemetry::TelemetryConfig::new().init();
 });
 
 #[derive(Debug)]

telemetry/examples/simple.rs

@@ -1,7 +1,7 @@
 use tracing::{debug, error, info, trace, warn};
 
 fn main() {
-    let _guard = orb_telemetry::TelemetryConfig::new().init();
+    let _telemetry_guard = orb_telemetry::TelemetryConfig::new().init();
 
     trace!("TRACE");
     debug!("DEBUG");

thermal-cam-ctrl/src/main.rs

@@ -110,7 +110,7 @@ enum Flow {
 
 fn main() -> Result<()> {
     color_eyre::install()?;
-    orb_telemetry::TelemetryConfig::new()
+    let _telemetry_guard = orb_telemetry::TelemetryConfig::new()
         .with_journald(SYSLOG_IDENTIFIER)
         .init();
 

ui/examples/ui-replay.rs

@@ -68,7 +68,7 @@ impl FromStr for EventRecord {
 #[tokio::main]
 async fn main() -> Result<()> {
     color_eyre::install()?;
-    orb_telemetry::TelemetryConfig::new().init();
+    let _telemetry_guard = orb_telemetry::TelemetryConfig::new().init();
 
     let args = Args::parse();
     let connection = Connection::session().await?;

ui/src/main.rs

@@ -125,7 +125,7 @@ async fn get_hw_version() -> Result<Hardware> {
 #[tokio::main]
 async fn main() -> Result<()> {
     color_eyre::install()?;
-    orb_telemetry::TelemetryConfig::new()
+    let _telemetry_guard = orb_telemetry::TelemetryConfig::new()
         .with_journald(SYSLOG_IDENTIFIER)
         .init();
 

update-agent/src/main.rs

@@ -49,7 +49,7 @@ const CFG_ENV_VAR: &str = const_format::concatcp!(ENV_VAR_PREFIX, "CONFIG");
 const SYSLOG_IDENTIFIER: &str = "worldcoin-update-agent";
 
 fn main() -> UpdateAgentResult {
-    orb_telemetry::TelemetryConfig::new()
+    let _telemetry_guard = orb_telemetry::TelemetryConfig::new()
         .with_journald(SYSLOG_IDENTIFIER)
         .init();
 

update-agent/src/update/tests.rs

@@ -7,7 +7,7 @@ use crate::update::Update;
 //#[cfg(feature = "can-update-test")]
 #[ignore = "needs vcan interface"]
 pub fn try_can_update() -> eyre::Result<()> {
-    orb_telemetry::TelemetryConfig::new().try_init().ok();
+    let _telemetry_guard = orb_telemetry::TelemetryConfig::new().try_init().ok();
 
     let mut file = File::open("/mnt/scratch/app_mcu_main_test.bin")?;
 

update-agent/tests/main.rs

@@ -6,7 +6,7 @@ use std::{
 #[ignore = "requires specific block device"]
 #[test]
 fn test_blockdevice_size() {
-    orb_telemetry::TelemetryConfig::new().init();
+    let _telemetry_guard = orb_telemetry::TelemetryConfig::new().init();
 
     let mut block_device: File = std::fs::OpenOptions::new()
         .read(true)

update-verifier/src/main.rs

@@ -27,7 +27,7 @@ fn clap_v3_styles() -> Styles {
 
 fn main() -> color_eyre::Result<()> {
     color_eyre::install()?;
-    orb_telemetry::TelemetryConfig::new()
+    let _telemetry_guard = orb_telemetry::TelemetryConfig::new()
         .with_journald(SYSLOG_IDENTIFIER)
         .init();
     run().inspect_err(|error| error!(?error, "failed to run update-verifier"))