feat(als): add flag indicating LED interference #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fouge
force-pushed
the
fouge/als-diamond-evt
branch
from
e7e5a7e to
057a50e
Compare
on Diamond EVT, ALS sensor is located on the front unit, close to the front LEDs. That ones are interfering with the ALS readings. Make sure to mark the ALS reading as invalid if the front LEDs are on.
fouge
force-pushed
the
fouge/als-diamond-evt
branch
from
057a50e to
10f65cd
Compare
TheButlah
approved these changes
Jan 14, 2025
|
converted to draft until all of our codebase use zephyr 4.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on Diamond EVT, ALS sensor is located on the front unit, close to the front LEDs. That ones are interfering with the ALS readings. Make sure to mark the ALS reading as invalid if the front LEDs are on.