feat: add new opaque tamper message #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
force-pushed
the
ryanbutler-orbs-248-add-new-opaque-tamper-states-to-orb-messages
branch
from
e02494c to
6ac638b
Compare
|
Ive gotten confirmation from @mcmaster-tfh that this approach is fine btw. Also, I'll leave it a string for now, and when in the future we start encrypting the tamper info, we can make it a |
sri9311
reviewed
Jan 8, 2025
TheButlah
force-pushed
the
ryanbutler-orbs-248-add-new-opaque-tamper-states-to-orb-messages
branch
from
6df80d4 to
ad3f9ed
Compare
fouge
approved these changes
Jan 9, 2025
TheButlah
deleted the
ryanbutler-orbs-248-add-new-opaque-tamper-states-to-orb-messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the old tamper messages and introduces a new one. The payload will be a
stringand is opaque to the protobufs. Instead, the contents of the string will be deserialized at runtime by other software.