Deduplicate common messages #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
force-pushed
the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
2 times, most recently
from
d7deafa to
281c8d1
Compare
TheButlah
force-pushed
the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
from
281c8d1 to
c439077
Compare
TheButlah
force-pushed
the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
2 times, most recently
from
ff9f0d7 to
9a11d83
Compare
TheButlah
force-pushed
the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
from
9a11d83 to
8230d5f
Compare
fouge
reviewed
Oct 18, 2024
fouge
force-pushed
the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
from
823cfc3 to
bd214e8
Compare
fouge
force-pushed
the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
from
bd214e8 to
870a487
Compare
to make generation from Makefile in private repo works
fouge
force-pushed
the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
from
a3655d4 to
ba1d72c
Compare
fouge
approved these changes
Oct 21, 2024
1 task
TheButlah
deleted the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the way we were compiling our protos resulted in duplicated rust structs for all messages in the common file.
I've reworked everything to use much more sensible file names, shorter module names, and most importantly, to unify the common types.