Add graceful shutdown to all health check failures #908

danielle-tfh · 2025-01-10T14:53:40Z

Notes

enforce sending graceful shutdown signals to all nodes
argo CD only triggers graceful shutdown every 3 minutes meaning during roll outs we do not see all 3 pods having graceful shutdown
this shares between pods to start gracefully shutting down

eaypek-tfh · 2025-01-10T15:40:37Z

iris-mpc/src/bin/server.rs

    struct ReadyProbeResponse {
        image_name: String,
        uuid:       String,
+        shutdown:   bool,


a nit suggestion on naming:

Suggested change

shutdown: bool,

shutting_down: bool,

danielle-tfh force-pushed the add-graceful-shutdown-on-sigterms branch 3 times, most recently from 6c97f47 to 23b2764 Compare January 10, 2025 15:34

eaypek-tfh approved these changes Jan 10, 2025

View reviewed changes

Trigger graceful shutdown between nodes

22afaf5

danielle-tfh force-pushed the add-graceful-shutdown-on-sigterms branch from 23b2764 to 22afaf5 Compare January 10, 2025 15:46

danielle-tfh enabled auto-merge (squash) January 10, 2025 15:46

danielle-tfh disabled auto-merge January 10, 2025 15:52

danielle-tfh merged commit b5be236 into main Jan 10, 2025
13 checks passed

danielle-tfh deleted the add-graceful-shutdown-on-sigterms branch January 10, 2025 15:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add graceful shutdown to all health check failures #908

Add graceful shutdown to all health check failures #908

danielle-tfh commented Jan 10, 2025 •

edited

Loading

eaypek-tfh Jan 10, 2025

Add graceful shutdown to all health check failures #908

Add graceful shutdown to all health check failures #908

Conversation

danielle-tfh commented Jan 10, 2025 • edited Loading

Notes

eaypek-tfh Jan 10, 2025

Choose a reason for hiding this comment

danielle-tfh commented Jan 10, 2025 •

edited

Loading